Skip to content

[Forwardport] Prevent servers being slammed from many search suggestion requests #16896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2018
Merged

[Forwardport] Prevent servers being slammed from many search suggestion requests #16896

merged 3 commits into from
Sep 13, 2018

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#16669

Description

Currently when a customer is typing in the search suggestion box, every character that is typed is immediately sent to the server. Typical auto-complete boxes will have a delay before sending the request to ensure this doesn't happen. This PR simply uses underscore's debounce method to throttle the requests with a default amount of 300ms, following the default configuration of jQuery's delay method: https://api.jqueryui.com/autocomplete/#option-delay

Fixed Issues (if relevant)

  1. Search suggestions result in dozens of queued AJAX requests community-features#71

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-assigned this Jul 17, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 17, 2018
@nuzil nuzil self-requested a review July 19, 2018 11:15
nuzil
nuzil approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mage2pratik thank for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-2391 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit a744728 into magento:2.3-develop Sep 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 13, 2018
@ishakhsuvarov
ENGCOM-2391: [Forwardport] Prevent servers being slammed from many se…
c902ea9 
…arch suggestion requests #16896
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nuzil nuzil nuzil approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nuzil nuzil

@ishakhsuvarov ishakhsuvarov

Labels
Area: Frontend Component: Search Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mage2pratik @magento-engcom-team @nuzil @ishakhsuvarov @LordZardeck